@epriestley:

So the import logic seems to only work when a logged-in user is performing the current request. e.g. if you look at https://secure.phabricator.com/differential/diff/20824/ you can see I had hooked up a method by which to make GET requests to this logic. When I was logged in and hit a URL like https://code.redpointsoftware.com.au/doorkeeper/github-hook/?type=pull_request&payload=%7B%7D&id=hach-que:test:1, it would import successfully and the revision would update.

However, when GitHub sends it's service request, I still get hach-que:test:1 imported as a response (which means it ran through all of the logic), but the revision hasn't actually been updated.

I'm not sure whether this is because:

• Doorkeeper's import engine isn't behaving correctly with a public user or
• Application transactions aren't behaving correctly with a public user (even though they're given a different account)

You probably have a better idea of what's silently not doing it's job here than I do.

On an additional note, I've noticed that viewing revisions created by this synchronisation are far more slow to load in the web UI than normal revisions. I have no idea why.

Okay, so it's working now when GitHub makes the callback (I derped and got the username and repo around the wrong way when building the pull request ID). Here's an example:

Pull Request: https://github.com/hach-que/test/pull/2

Differential Revision: https://code.redpointsoftware.com.au/D269

@qgil I saw that WMF was looking at this to reduce contributor requirements. If you use this before it's converted to use Nuance, I can't guarantee that things aren't going to break horribly if and when this gets upstreamed. Usage of the (non-existant but planned) Nuance infrastructure solves a lot of otherwise-hard-to-solve problems, so at the very least, all the integration points will change.

@hach-que, thank you for the background. No worries, there are still many steps that need to be completed before thinking about this feature for our users.