Page MenuHomePhabricator
Differential D8768

Remove several "loadArcanistProject()" methods
ClosedPublic
Actions

Authored by epriestley on Apr 13 2014, 12:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 10:49 AM
Unknown Object (File)
Thu, Dec 5, 5:55 AM
Unknown Object (File)
Oct 23 2024, 2:42 PM
Unknown Object (File)
Oct 20 2024, 3:13 AM
Unknown Object (File)
Oct 18 2024, 3:35 PM
Unknown Object (File)
Sep 15 2024, 5:44 PM
Unknown Object (File)
Sep 15 2024, 6:20 AM
Unknown Object (File)
Aug 28 2024, 4:55 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPf4c8a34abe8a: Remove several "loadArcanistProject()" methods
Summary

Ref T3551. Releeph has old-style loadX() methods; get rid of one of them.

Differential has a couple of copies of this too, clean them up.

Test Plan
  • Viewed various differential revisions (with and without projects).
  • Viewed and edited Releeph products.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20795.Apr 13 2014, 12:35 AM
epriestley retitled this revision from to Remove several "loadArcanistProject()" methods.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2716: Consolidate "load commit from name" code.
Herald added a subscriber: epriestley.Apr 13 2014, 12:35 AM
epriestley updated this object.Apr 13 2014, 12:36 AM
epriestley added a task: Restricted Maniphest Task.
epriestley added inline comments.
src/applications/differential/storage/DifferentialDiff.php
98

This was only called by the next method.

107

This has no callers. There's a getSourceControlSystem() which I think obsoleted it long ago.

btrahan accepted this revision.Apr 14 2014, 12:42 AM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 14 2014, 12:42 AM
epriestley closed this revision.Apr 14 2014, 7:07 PM
epriestley updated this revision to Diff 20810.

Closed by commit rPf4c8a34abe8a (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
16 lines
storage/
21 lines
releeph/
controller/
project/
3 lines
2 lines
query/
3 lines
29 lines
storage/
14 lines

Diff 20810

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/storage/DifferentialDiff.php

Loading...
View Options

src/applications/releeph/controller/project/ReleephProductEditController.php

Loading...
View Options

src/applications/releeph/controller/project/ReleephProductListController.php

Loading...
View Options

src/applications/releeph/query/ReleephProductSearchEngine.php

Loading...
View Options

src/applications/releeph/query/ReleephProjectQuery.php

Loading...
View Options

src/applications/releeph/storage/ReleephProject.php

Loading...
Phabricator · Built by Phacility