Page MenuHomePhabricator

Add DifferentialHunkQuery to start hiding hunk storage details
ClosedPublic

Authored by epriestley on Apr 12 2014, 1:40 PM.
Tags
None
Referenced Files
F14064544: D8765.diff
Mon, Nov 18, 11:55 PM
F14008318: D8765.id.diff
Tue, Oct 29, 7:29 PM
F14004480: D8765.diff
Sat, Oct 26, 9:18 PM
F13984009: D8765.id20807.diff
Sun, Oct 20, 10:20 AM
F13982709: D8765.diff
Oct 20 2024, 1:18 AM
F13975344: D8765.diff
Oct 18 2024, 9:45 AM
Unknown Object (File)
Oct 7 2024, 1:16 PM
Unknown Object (File)
Oct 6 2024, 1:47 PM
Subscribers

Details

Summary

Ref T4045. We have a lot of direct queries against the hunk table right now. These are messy, not really policy-aware, and limit our options on T4045.

This query is unusual (it requires changesets, and does not accept IDs). This keeps us from having to load changeset -> diff -> revision in order to do policy checks. We could also fix this with smarter policy checks and caching, but I'd rather not open that can of worms for now. This object is very low level and relatively unusual, and this small deviation from convention seems like the cleanest cut to make to keep this from snowballing.

Test Plan

Used Herald dry runs to verify that the affected rules still output the same data.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Add DifferentialHunkQuery to start hiding hunk storage details.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 14 2014, 6:37 PM
epriestley updated this revision to Diff 20807.

Closed by commit rP6899fbcf2966 (authored by @epriestley).