Differential D8762

Adding getBoundingClientRect math to getPos in Vector.js
ClosedPublic
Actions

Authored by lpriestley on Apr 11 2014, 10:39 PM.

Tags

None

Referenced Files

	F14343468: D8762.id20782.diff
	Thu, Dec 19, 12:09 AM

	F14343390: D8762.id20784.diff
	Thu, Dec 19, 12:06 AM

	Unknown Object (File)
	Sat, Dec 14, 10:13 AM

	Unknown Object (File)
	Thu, Dec 12, 12:46 AM

	Unknown Object (File)
	Sat, Dec 7, 5:29 AM

	Unknown Object (File)
	Wed, Dec 4, 7:46 PM

	Unknown Object (File)
	Tue, Dec 3, 4:34 AM

	Unknown Object (File)
	Thu, Nov 28, 3:39 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4714: Tooltips do not appear in when editor is in fullscreen mode

Commits

Restricted Diffusion Commit
rP8af84a9b7da3: Adding getBoundingClientRect math to getPos in Vector.js

Summary

Ref T4714, tooltips in fullscreen mode need special math, due to fixed position throwing off position of tooltips.

Test Plan

Create work board, create several tasks, create several columns, drag tasks among columns and within columns. Create a paste, check tooltips in comment box show and are positioned correctly. Fullscreen comment box. Verify tooltips still show and position correctly.

Diff Detail

Repository

Branch

boundsrect

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

lpriestley updated this revision to Diff 20782.Apr 11 2014, 10:39 PM

lpriestley retitled this revision from to Adding getBoundingClientRect math to getPos in Vector.js.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T4714: Tooltips do not appear in when editor is in fullscreen mode.

Herald added a reviewer: Blessed Reviewers.Apr 11 2014, 10:39 PM

Herald added subscribers: Korvin, epriestley.

This is essentially the modern jQuery implementation, too:

https://github.com/jquery/jquery/blob/master/src/offset.js

This revision is now accepted and ready to land.Apr 11 2014, 11:09 PM

Closed by commit rP8af84a9b7da3 (authored by @lkassianik, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

16 lines

webroot/

rsrc/

externals/

javelin/

lib/

7 lines

Diff 20782

resources/celerity/map.php

Loading...

webroot/rsrc/externals/javelin/lib/Vector.js

Loading...