Page MenuHomePhabricator

Adding getBoundingClientRect math to getPos in Vector.js
ClosedPublic

Authored by lpriestley on Apr 11 2014, 10:39 PM.

Details

Summary

Ref T4714, tooltips in fullscreen mode need special math, due to fixed position throwing off position of tooltips.

Test Plan

Create work board, create several tasks, create several columns, drag tasks among columns and within columns. Create a paste, check tooltips in comment box show and are positioned correctly. Fullscreen comment box. Verify tooltips still show and position correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

lpriestley retitled this revision from to Adding getBoundingClientRect math to getPos in Vector.js.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.

This is essentially the modern jQuery implementation, too:

https://github.com/jquery/jquery/blob/master/src/offset.js

This revision is now accepted and ready to land.Apr 11 2014, 11:09 PM
epriestley updated this revision to Diff 20784.

Closed by commit rP8af84a9b7da3 (authored by @lkassianik, committed by @epriestley).