Page MenuHomePhabricator

Arcanist - fix shouldAmend code
ClosedPublic

Authored by btrahan on Apr 11 2014, 8:07 PM.
Tags
None
Referenced Files
F15415080: D8761.diff
Thu, Mar 20, 3:53 AM
Unknown Object (File)
Feb 11 2025, 6:25 AM
Unknown Object (File)
Feb 9 2025, 12:16 PM
Unknown Object (File)
Feb 9 2025, 12:16 PM
Unknown Object (File)
Feb 9 2025, 12:16 PM
Unknown Object (File)
Feb 9 2025, 12:16 PM
Unknown Object (File)
Feb 6 2025, 9:32 PM
Unknown Object (File)
Feb 6 2025, 6:36 PM
Subscribers

Details

Summary

make it a real member variable. See rARC77a9c1814063 and D8753#33914.

Test Plan

sending up this diff!

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Arcanist - fix shouldAmend code.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, shadowhand.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 11 2014, 8:07 PM
btrahan updated this revision to Diff 20780.

Closed by commit rARC43792895a679 (authored by @btrahan).

Makes more sense now. Thanks. :)