Arcanist - fix shouldAmend code
ClosedPublic
Actions

Authored by btrahan on Apr 11 2014, 8:07 PM.

Tags

None

Referenced Files

	F18741175: D8761.id20780.diff
	Thu, Oct 2, 9:04 AM

	F18658045: D8761.diff
	Tue, Sep 23, 4:33 AM

	F18617785: D8761.id.diff
	Sun, Sep 14, 10:09 PM

	F18603915: D8761.diff
	Sat, Sep 13, 5:44 PM

	F18129929: D8761.diff
	Aug 13 2025, 6:33 PM

	F18107194: D8761.id.diff
	Aug 10 2025, 11:45 PM

	F17950365: D8761.diff
	Aug 1 2025, 12:20 AM

	F17938381: D8761.id20780.diff
	Jul 31 2025, 2:08 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley
shadowhand

Commits

rARC43792895a679: Arcanist - fix shouldAmend code

Summary

make it a real member variable. See rARC77a9c1814063 and D8753#33914.

Test Plan

sending up this diff!

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 20779.Apr 11 2014, 8:07 PM

btrahan retitled this revision from to Arcanist - fix shouldAmend code.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, shadowhand.

Herald added subscribers: Korvin, epriestley.Apr 11 2014, 8:07 PM

epriestley accepted this revision.Apr 11 2014, 8:07 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 11 2014, 8:07 PM

Closed by commit rARC43792895a679 (authored by @btrahan).

Makes more sense now. Thanks. :)

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistBaseWorkflow.php

12 lines

Diff 20780

View Options

src/workflow/ArcanistBaseWorkflow.php

Arcanist - fix shouldAmend codeClosedPublicActions