Page MenuHomePhabricator

Arcanist - fix shouldAmend code
ClosedPublic

Authored by btrahan on Apr 11 2014, 8:07 PM.
Tags
None
Referenced Files
F18129929: D8761.diff
Wed, Aug 13, 6:33 PM
F18107194: D8761.id.diff
Sun, Aug 10, 11:45 PM
F17950365: D8761.diff
Fri, Aug 1, 12:20 AM
F17938381: D8761.id20780.diff
Thu, Jul 31, 2:08 AM
Unknown Object (File)
Jun 9 2025, 2:08 AM
Unknown Object (File)
May 18 2025, 8:22 AM
Unknown Object (File)
May 7 2025, 7:07 PM
Unknown Object (File)
Apr 23 2025, 2:23 AM
Subscribers

Details

Summary

make it a real member variable. See rARC77a9c1814063 and D8753#33914.

Test Plan

sending up this diff!

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Arcanist - fix shouldAmend code.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, shadowhand.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 11 2014, 8:07 PM
btrahan updated this revision to Diff 20780.

Closed by commit rARC43792895a679 (authored by @btrahan).

Makes more sense now. Thanks. :)