Differential - make diffs you authored + are reviewer for show up in appropos boxes
ClosedPublic
Actions

Authored by btrahan on Apr 11 2014, 12:27 AM.

Details

Reviewers

Maniphest Tasks

Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rPf86ab666f6bc: Differential - make diffs you authored + are reviewer for show up in appropos…

Summary

Fixes T2328. Note the audit part is fixed now.

Test Plan

Tried to reproduce the audit issue by raising my own commit as a problem; it showed up before code changes! Made a diff with my self as author and reviewer; it showed up as expected

Diff Detail

Repository

rP Phabricator

Branch

T2328

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

btrahan updated this revision to Diff 20761.Apr 11 2014, 12:27 AM

btrahan added a task: Restricted Maniphest Task.

btrahan retitled this revision from to Differential - make diffs you authored + are reviewer for show up in appropos boxes.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley.Apr 11 2014, 12:27 AM

btrahan added inline comments.Apr 11 2014, 12:29 AM

src/applications/differential/query/DifferentialRevisionQuery.php
1033–1034	$allow_self gets used again later. the logic there ends up working since a !$viewer_phid is earlier in the if / else, but I had to think about it enough i chose to pull it out here for clarity / assurance for the next person.

epriestley accepted this revision.Apr 11 2014, 11:32 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 11 2014, 11:32 AM

Closed by commit rPf86ab666f6bc (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

query/

DifferentialRevisionQuery.php

15 lines

Diff 20761

View Options

src/applications/differential/query/DifferentialRevisionQuery.php

Differential - make diffs you authored + are reviewer for show up in appropos boxesClosedPublicActions