Page MenuHomePhabricator

Modernize chatlog a bit
ClosedPublic

Authored by epriestley on Apr 10 2014, 4:20 PM.
Tags
None
Referenced Files
F14017489: D8746.id20748.diff
Mon, Nov 4, 5:45 PM
F13998383: D8746.diff
Thu, Oct 24, 9:14 AM
F13998372: D8746.id.diff
Thu, Oct 24, 9:09 AM
F13998370: D8746.id20741.diff
Thu, Oct 24, 9:08 AM
F13998363: D8746.id20748.diff
Thu, Oct 24, 9:06 AM
F13995393: D8746.diff
Wed, Oct 23, 12:32 PM
F13992145: D8746.id.diff
Tue, Oct 22, 2:37 PM
F13986757: D8746.id20741.diff
Mon, Oct 21, 5:19 AM
Subscribers

Details

Summary

Ref T4786. This doesn't fully fix the issue since there's no way to make channels public yet, but gets some of the infrastructure more up to date.

  • Allow public access to the list and log controllers.
  • Implement proper policy checks in the Events (this has no practical impact on the only controller that loads this stuff, it's just for general/future purposes).
  • Remove a old-style unused method for building page frames.
Test Plan

Viewed log list and log details as logged-in and logged out users.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Modernize chatlog a bit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 10 2014, 6:30 PM
epriestley updated this revision to Diff 20748.

Closed by commit rPfacd3ea8ef5a (authored by @epriestley).