Page MenuHomePhabricator

Modernize chatlog a bit
ClosedPublic

Authored by epriestley on Apr 10 2014, 4:20 PM.
Tags
None
Referenced Files
F18734755: D8746.diff
Tue, Sep 30, 11:01 PM
F18664467: D8746.diff
Wed, Sep 24, 12:00 AM
F18659177: D8746.id20748.diff
Tue, Sep 23, 10:17 AM
F18642156: D8746.id.diff
Sep 18 2025, 10:43 PM
F18198061: D8746.id.diff
Aug 17 2025, 10:30 PM
F18194628: D8746.id20748.diff
Aug 17 2025, 11:20 AM
F18193702: D8746.id20741.diff
Aug 17 2025, 6:26 AM
F18189045: D8746.diff
Aug 16 2025, 9:33 PM
Subscribers

Details

Summary

Ref T4786. This doesn't fully fix the issue since there's no way to make channels public yet, but gets some of the infrastructure more up to date.

  • Allow public access to the list and log controllers.
  • Implement proper policy checks in the Events (this has no practical impact on the only controller that loads this stuff, it's just for general/future purposes).
  • Remove a old-style unused method for building page frames.
Test Plan

Viewed log list and log details as logged-in and logged out users.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Modernize chatlog a bit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 10 2014, 6:30 PM
epriestley updated this revision to Diff 20748.

Closed by commit rPfacd3ea8ef5a (authored by @epriestley).