Makes the default 3 rows on mobile devices, with larger fonts. Differential/Audit is much better, Maniphest is maybe a sidegrade depending on setup.
Details
Details
- Reviewers
epriestley - Commits
- Restricted Diffusion Commit
rP3018a5eb0912: Better mobile display of ObjectItemView
test maniphest, audit, differential list items.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- object-list-item-view
- Lint
Lint Passed - Unit
No Test Coverage
Event Timeline
Comment Actions
One thought I've had about titles getting truncated is that we could put a little transparent-to-grey gradient over the last, say, 12 pixels of them, so the right hand side would fade out over the span of a character or so, instead of cutting off abruptly. I think the current behavior overall is fine, but it looks a little unintentional right now when we cut abruptly in the middle of a character, and right at the edge.
Other simpler fixes might be:
- Cut abruptly, but leave a few pixels of border between the cut position and the edge, so it's more clear that the cut is intentional?
- Use "text-overflow: ellipsis" -- we'll lose a bit of information and I'm not sure this is supported everywhere yet, and some of the positioning tricks might make it messy, but it would look clearly intentional?
Comment Actions
Yeah, this isn't perfect. With text-overflow you still need to know the width I think. I considered just removing the icon, but went this way instead which seemed slightly better.
Comment Actions
The icon one looks good to me in the new stuff, it's just this that still looks like it's not intentional, since it's smushing right into the edge there:
Comment Actions
oh that, yeah... let me see what solutions there may be. It's not a regression at least, just always been slightly jank.