Page MenuHomePhabricator
Differential D8722

Add an "Always Search" flag to the libphutil LDAP adapter
ClosedPublic
Actions

Authored by epriestley on Apr 8 2014, 6:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 9:59 PM
Unknown Object (File)
Sat, Apr 20, 6:45 PM
Unknown Object (File)
Fri, Apr 12, 9:45 PM
Unknown Object (File)
Sat, Mar 30, 9:48 PM
Unknown Object (File)
Sat, Mar 30, 11:31 AM
Unknown Object (File)
Mar 23 2024, 2:08 PM
Unknown Object (File)
Feb 17 2024, 1:03 AM
Unknown Object (File)
Feb 17 2024, 1:03 AM
View All Files
Subscribers
epriestley

Details

Reviewers
Firehed
Maniphest Tasks
Restricted Maniphest Task
Commits
rPHU3435a259ab0f: Add an "Always Search" flag to the libphutil LDAP adapter
Summary

Ref T3208. This adds a flag which acts like the old "Search First" flag did, more or less, probably. LDAP?

Specifically, the issue at heart here is that some LDAP servers require totally uncredentialed binds, some require "anonymous" binds (not sure if this is a term of art or if whoever contributed the first LDAP patch made it up), and some require full DN binds. This flag lets us distinguish between the "full DN" and "completely uncredentialed" use cases, both of which have no "anonymous" credentials.

Test Plan

It compiles!

Diff Detail

Repository
rPHU libphutil
Branch
ldap1
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

epriestley updated this revision to Diff 20683.Apr 8 2014, 6:13 PM
epriestley retitled this revision from to Add an "Always Search" flag to the libphutil LDAP adapter.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: Firehed.
epriestley added a task: Restricted Maniphest Task.
Herald added a subscriber: epriestley.Apr 8 2014, 6:13 PM
Firehed accepted this revision.Apr 8 2014, 6:28 PM
Firehed edited edge metadata.

Worked on my install combined with D8723 :D

This revision is now accepted and ready to land.Apr 8 2014, 6:28 PM
Firehed added a comment.Apr 8 2014, 6:29 PM

Also tested that incorrect credentials fail. Because, you know, security. All looks good here!

epriestley added a comment.Apr 8 2014, 6:30 PM

Awesome, thanks!

epriestley closed this revision.Apr 8 2014, 6:36 PM
epriestley updated this revision to Diff 20685.

Closed by commit rPHU3435a259ab0f (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
auth/
47 lines

Diff 20683

View Options

src/auth/PhutilAuthAdapterLDAP.php

Loading...
Phabricator · Built by Phacility