Fix parsing and storage of generated SSH keys
ClosedPublic
Actions

Authored by epriestley on Apr 8 2014, 5:24 PM.

Tags

None

Referenced Files

	F15307748: D8721.id20692.diff
	Thu, Mar 6, 5:29 AM

	Unknown Object (File)
	Tue, Feb 25, 3:32 PM

	Unknown Object (File)
	Tue, Feb 25, 3:32 PM

	Unknown Object (File)
	Mon, Feb 24, 11:39 AM

	Unknown Object (File)
	Feb 5 2025, 1:32 AM

	Unknown Object (File)
	Feb 5 2025, 12:52 AM

	Unknown Object (File)
	Jan 28 2025, 6:43 PM

	Unknown Object (File)
	Jan 25 2025, 2:12 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Maniphest Tasks

T4772: Generated keys are "not formatted properly" when you try to edit them

Commits

Restricted Diffusion Commit
rP563a1ac5bf3c: Fix parsing and storage of generated SSH keys

Summary

Fixes T4772. We weren't parsing generated public keys properly, and were storing them in the wrong format.

Test Plan

Updated a private key.
Generated a public key.
Saved the public key.
Used a generated private key to authenticate.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20679.Apr 8 2014, 5:24 PM

epriestley retitled this revision from to Fix parsing and storage of generated SSH keys.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4772: Generated keys are "not formatted properly" when you try to edit them.

Herald added a subscriber: epriestley.Apr 8 2014, 5:25 PM

btrahan accepted this revision.Apr 8 2014, 9:52 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 8 2014, 9:52 PM

Closed by commit rP563a1ac5bf3c (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

panel/

PhabricatorSettingsPanelSSHKeys.php

105 lines

Diff 20692

View Options

src/applications/settings/panel/PhabricatorSettingsPanelSSHKeys.php

Fix parsing and storage of generated SSH keysClosedPublicActions