Page MenuHomePhabricator

Don't disrupt repository import chain when publishing is disabled
ClosedPublic

Authored by epriestley on Apr 7 2014, 1:20 PM.
Tags
None
Referenced Files
F15459170: D8715.id.diff
Mon, Mar 31, 10:31 AM
F15451047: D8715.id20670.diff
Fri, Mar 28, 7:52 PM
F15445020: D8715.id20664.diff
Thu, Mar 27, 12:19 PM
F15386333: D8715.id20664.diff
Sat, Mar 15, 12:23 AM
F15383973: D8715.id20664.diff
Fri, Mar 14, 6:29 PM
F15381624: D8715.diff
Fri, Mar 14, 8:39 AM
F15367259: D8715.diff
Tue, Mar 11, 4:45 PM
F15343057: D8715.id20664.diff
Sun, Mar 9, 10:10 PM
Subscribers

Details

Summary

Fixes T4736. Currently, we incorrectly skip the writeImportStatusFlag() call if publishing is disabled (the herald-disabled) check. This means we don't flag the commit as imported, and don't move the pipeline forward correctly.

Instead, we only want to skip the owners stuff, not the pipeline stuff. Move that to a method.

(Also fix a nearby TODO now that we have a permanent failure exception.)

Test Plan
  • Used scripts/repository/reparse.php --owners ... to execute this code, fiddled with things to hit both the disabled and enabled branches and verified the flag stuff is still reached.
  • Faked the exceptions and made sure they raise correctly.

Diff Detail

Repository
rP Phabricator
Branch
ownersherald
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley retitled this revision from to Don't disrupt repository import chain when publishing is disabled.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 7 2014, 5:31 PM
epriestley updated this revision to Diff 20670.

Closed by commit rPbd0011076ba1 (authored by @epriestley).