Paths

Table of Contentst

Differential D8715

Don't disrupt repository import chain when publishing is disabled
ClosedPublic
Actions

Authored by epriestley on Apr 7 2014, 1:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 19, 10:21 AM

	Unknown Object (File)
	Wed, Dec 4, 4:01 AM

	Unknown Object (File)
	Sat, Nov 30, 10:12 AM

	Unknown Object (File)
	Sat, Nov 30, 4:55 AM

	Unknown Object (File)
	Sat, Nov 30, 4:51 AM

	Unknown Object (File)
	Sat, Nov 30, 4:51 AM

	Unknown Object (File)
	Tue, Nov 26, 12:14 PM

	Unknown Object (File)
	Tue, Nov 26, 12:14 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T4736: Disabling Herald incorrectly terminates commit import pipeline

Commits

Restricted Diffusion Commit
rPbd0011076ba1: Don't disrupt repository import chain when publishing is disabled

Summary

Fixes T4736. Currently, we incorrectly skip the writeImportStatusFlag() call if publishing is disabled (the herald-disabled) check. This means we don't flag the commit as imported, and don't move the pipeline forward correctly.

Instead, we only want to skip the owners stuff, not the pipeline stuff. Move that to a method.

(Also fix a nearby TODO now that we have a permanent failure exception.)

Test Plan

Used scripts/repository/reparse.php --owners ... to execute this code, fiddled with things to hit both the disabled and enabled branches and verified the flag stuff is still reached.
Faked the exceptions and made sure they raise correctly.

Diff Detail

Repository

Branch

ownersherald

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

epriestley updated this revision to Diff 20664.Apr 7 2014, 1:20 PM

epriestley retitled this revision from to Don't disrupt repository import chain when publishing is disabled.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4736: Disabling Herald incorrectly terminates commit import pipeline.

Herald added a subscriber: epriestley.Apr 7 2014, 1:20 PM

Debugging code snuck in.

btrahan accepted this revision.Apr 7 2014, 5:31 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 7 2014, 5:31 PM

Closed by commit rPbd0011076ba1 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

worker/

PhabricatorRepositoryCommitOwnersWorker.php

29 lines

PhabricatorRepositoryCommitParserWorker.php

7 lines

Diff 20665

src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php

Loading...

src/applications/repository/worker/PhabricatorRepositoryCommitParserWorker.php

Loading...