Page MenuHomePhabricator

Don't disrupt repository import chain when publishing is disabled
ClosedPublic

Authored by epriestley on Apr 7 2014, 1:20 PM.
Tags
None
Referenced Files
F18621343: D8715.id.diff
Sep 15 2025, 7:50 AM
F18617867: D8715.id20670.diff
Sep 14 2025, 10:26 PM
F18610171: D8715.diff
Sep 14 2025, 4:24 AM
F18610167: D8715.diff
Sep 14 2025, 4:23 AM
F18045480: D8715.id20664.diff
Aug 3 2025, 9:03 AM
F17925437: D8715.id20665.diff
Jul 30 2025, 11:31 AM
F17895357: D8715.id.diff
Jul 29 2025, 6:12 AM
F17869174: D8715.diff
Jul 28 2025, 10:43 AM
Subscribers

Details

Summary

Fixes T4736. Currently, we incorrectly skip the writeImportStatusFlag() call if publishing is disabled (the herald-disabled) check. This means we don't flag the commit as imported, and don't move the pipeline forward correctly.

Instead, we only want to skip the owners stuff, not the pipeline stuff. Move that to a method.

(Also fix a nearby TODO now that we have a permanent failure exception.)

Test Plan
  • Used scripts/repository/reparse.php --owners ... to execute this code, fiddled with things to hit both the disabled and enabled branches and verified the flag stuff is still reached.
  • Faked the exceptions and made sure they raise correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Don't disrupt repository import chain when publishing is disabled.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 7 2014, 5:31 PM
epriestley updated this revision to Diff 20670.

Closed by commit rPbd0011076ba1 (authored by @epriestley).