Page MenuHomePhabricator

Set from name when $can_send_as_user is true
ClosedPublic

Authored by sophiebits on Apr 4 2014, 12:43 AM.
Tags
None
Referenced Files
F12835298: D8694.diff
Thu, Mar 28, 3:05 PM
Unknown Object (File)
Feb 13 2024, 2:18 AM
Unknown Object (File)
Feb 4 2024, 7:20 PM
Unknown Object (File)
Feb 4 2024, 7:20 PM
Unknown Object (File)
Feb 4 2024, 3:18 AM
Unknown Object (File)
Jan 23 2024, 4:01 PM
Unknown Object (File)
Jan 15 2024, 5:15 PM
Unknown Object (File)
Dec 19 2023, 8:00 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP133772d7eb1f: Set from name when $can_send_as_user is true
Test Plan

Crossed fingers.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sophiebits retitled this revision from to Set from name when $can_send_as_user is true.
sophiebits updated this object.
sophiebits edited the test plan for this revision. (Show Details)
sophiebits added a reviewer: epriestley.
This revision is now accepted and ready to land.Apr 4 2014, 12:44 AM
src/applications/metamta/storage/PhabricatorMetaMTAMail.php
365

Also I wonder if this clause should maybe be like if ($can_send_as_user && ($actor_email !== null)).

src/applications/metamta/storage/PhabricatorMetaMTAMail.php
365

Well, we have

$can_send_as_user = $actor_email &&
  PhabricatorEnv::getEnvConfig('metamta.can-send-as-user');

which I assumed was good enough.

365

Or did you mean just store the config option in that var?

epriestley updated this revision to Diff 20623.

Closed by commit rP133772d7eb1f (authored by @spicyj, committed by @epriestley).