Page MenuHomePhabricator
Differential D8693

Add colgroup in differential "shield" tables
ClosedPublic
Actions

Authored by sophiebits on Apr 3 2014, 10:06 PM.
Tags
None
Referenced Files
F14077343: D8693.diff
Thu, Nov 21, 10:50 PM
Unknown Object (File)
Tue, Nov 19, 12:41 PM
Unknown Object (File)
Tue, Nov 12, 9:23 PM
Unknown Object (File)
Oct 15 2024, 6:25 AM
Unknown Object (File)
Oct 13 2024, 10:35 AM
Unknown Object (File)
Oct 11 2024, 11:04 AM
Unknown Object (File)
Oct 11 2024, 2:49 AM
Unknown Object (File)
Oct 10 2024, 11:01 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPa0ac3d67168b: Add colgroup in differential "shield" tables
Summary

Fixes minor brokenness from D8686.

Test Plan

Expanded a generated file, saw a normal-looking diff.

Diff Detail

Repository
rP Phabricator
Branch
colgroup-shield
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

sophiebits updated this revision to Diff 20619.Apr 3 2014, 10:06 PM
sophiebits retitled this revision from to Add colgroup in differential "shield" tables.
sophiebits updated this object.
sophiebits edited the test plan for this revision. (Show Details)
sophiebits added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers.Apr 3 2014, 10:06 PM
Herald added subscribers: Korvin, epriestley.
epriestley accepted this revision.Apr 3 2014, 10:10 PM
epriestley edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Apr 3 2014, 10:10 PM
epriestley closed this revision.Apr 3 2014, 10:50 PM
epriestley updated this revision to Diff 20620.

Closed by commit rPa0ac3d67168b (authored by @spicyj, committed by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
differential/
render/
16 lines
17 lines

Diff 20619

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...
Phabricator · Built by Phacility