Mobile Differential Diff Review (2-up)
ClosedPublic
Actions

Authored by chad on Apr 2 2014, 9:02 PM.

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rP3005b7a7b114: Mobile Differential Diff Review (2-up)

Summary

This does two things

Modernizes Table of Contents
Makes Differential reasonable on mobile

I say resonable, as you still have to scroll horizontal to see the entire diff. This is minor as the rest of the page is 100x more useful. A 1-up view would be preferred, but this is still an improvement.

Test Plan

Used iOS simulator for browsing diffs.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad updated this revision to Diff 20587.Apr 2 2014, 9:02 PM

chad retitled this revision from to Mobile Differential Diff Review (2-up).

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: chad, Korvin, epriestley.Apr 2 2014, 9:02 PM

I think the leftmost column (with "A" and "M") should be left-aligned for visual consistency with svn st and similar (in various cases, more than one letter will appear there -- your test cases might have only had one). This looks good to me otherwise.

This revision is now accepted and ready to land.Apr 2 2014, 9:22 PM