Page MenuHomePhabricator

Make "JIRA Issues" field work better with noncredentialed accounts
ClosedPublic

Authored by epriestley on Apr 2 2014, 6:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 9:08 AM
Unknown Object (File)
Fri, Jan 17, 10:25 PM
Unknown Object (File)
Mon, Jan 6, 5:11 PM
Unknown Object (File)
Dec 20 2024, 3:22 PM
Unknown Object (File)
Dec 19 2024, 3:37 AM
Unknown Object (File)
Dec 12 2024, 5:08 PM
Unknown Object (File)
Dec 11 2024, 7:05 PM
Unknown Object (File)
Nov 20 2024, 2:29 PM

Details

Summary

Currently, users get an error when making any changes to this field if they don't have a linked JIRA account.

Instead:

  • We should only raise an error if they're trying to add issues, and only on the new issues. It's always fine to remove issues, and existing issues the author can't see are also fine.
  • When we can't add things because there's no account (vs because there's a permissions error or they don't exist), raise a more tailored exception.
Test Plan
  • As JIRA and non-JIRA users, made various edits to this field.
  • Got appropriate exceptions, including better tailoring.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Make "JIRA Issues" field work better with noncredentialed accounts.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 2 2014, 6:40 PM
epriestley updated this revision to Diff 20574.

Closed by commit rP81fa847bc52b (authored by @epriestley).