Page MenuHomePhabricator
Differential D8657

Restore "Branch" and "changes since last update" fields to Differential mail
ClosedPublic
Actions

Authored by epriestley on Mar 31 2014, 7:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 5:41 AM
Unknown Object (File)
Mon, Dec 16, 2:02 AM
Unknown Object (File)
Mon, Dec 16, 1:55 AM
Unknown Object (File)
Mon, Dec 16, 1:55 AM
Unknown Object (File)
Mon, Dec 16, 1:55 AM
Unknown Object (File)
Mon, Dec 16, 12:54 AM
Unknown Object (File)
Fri, Dec 13, 6:47 PM
Unknown Object (File)
Fri, Dec 13, 1:48 PM
View All Files
Subscribers
epriestley
sophiebits

Details

Reviewers
btrahan
Maniphest Tasks
T418: Integrate CustomField into more interfaces
T4642: Put the "branch" field back in Differential email
Commits
Restricted Diffusion Commit
rPcf6f7446ce3f: Restore "Branch" and "changes since last update" fields to Differential mail
Summary

Ref T418. Fixes T4642. The "changes since last update" and "branch" fields got dropped; restore them in a general, field-driven way.

Test Plan
  • Created a revision, got relevant sections in mail.
  • Commented on a revision, got relevant sections in mail.
  • Updated a revision, got relevant sections in mail.

Diff Detail

Repository
rP Phabricator
Branch
dxmail
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Diff 20529.Mar 31 2014, 7:28 PM
epriestley retitled this revision from to Restore "Brach" and "changes since last update" fields to Differential mail.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T4642: Put the "branch" field back in Differential email, T418: Integrate CustomField into more interfaces.
Herald added a subscriber: epriestley.Mar 31 2014, 7:28 PM
chad retitled this revision from Restore "Brach" and "changes since last update" fields to Differential mail to Restore "Branch" and "changes since last update" fields to Differential mail.Mar 31 2014, 8:16 PM
sophiebits added a subscriber: sophiebits.Mar 31 2014, 8:39 PM

Thanks for this!

src/applications/differential/customfield/DifferentialBranchField.php
62

It's also useful to have the branch shown when a diff is accepted and ready to land.

epriestley added a comment.Mar 31 2014, 8:42 PM

(Out of curiosity, do you use arc branch? And/or would arc land D123 be useful? I assume you're using the BRANCH field to copy-paste to the CLI?)

epriestley updated this revision to Diff 20532.Mar 31 2014, 8:48 PM
  • Also show the field for accepted revisions.
sophiebits added a comment.Mar 31 2014, 8:52 PM

Ooh! No, I didn't know about arc branch. I do think being able to say arc land D123 would also be useful.

btrahan accepted this revision.Mar 31 2014, 9:35 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 31 2014, 9:35 PM
epriestley closed this revision.Apr 1 2014, 3:23 PM
epriestley updated this revision to Diff 20543.

Closed by commit rPcf6f7446ce3f (authored by @epriestley).

Revision Contents
Changeset List

Diff 20529

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

Loading...
View Options

src/applications/differential/customfield/DifferentialBranchField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialChangesSinceLastUpdateField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialSummaryField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialTestPlanField.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
View Options

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...
Phabricator · Built by Phacility