Paths

Table of Contentst

Fix JIRA integration from "arc" commit messages
ClosedPublic
Actions

Authored by epriestley on Mar 31 2014, 3:08 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T4683: JIRA/arc diff integration appears to have broken

Commits

Restricted Diffusion Commit
rP3aabfc7f4dea: Fix JIRA integration from "arc" commit messages

Summary

Fixes T4683. This was just a missing method implementation. Also provide a couple of translation things.

Test Plan

Created a revision from the command line with a nonempty JIRA Issues: line, via arc diff.
Looked at the translation strings.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20527.Mar 31 2014, 3:08 PM

epriestley retitled this revision from to Fix JIRA integration from "arc" commit messages.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

epriestley added a task: T4683: JIRA/arc diff integration appears to have broken.

Herald added a subscriber: epriestley.Mar 31 2014, 3:08 PM

chad accepted this revision.Mar 31 2014, 3:39 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 31 2014, 3:39 PM

Closed by commit rP3aabfc7f4dea (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

customfield/

DifferentialJIRAIssuesField.php

8 lines

infrastructure/

internationalization/

translation/

PhabricatorBaseEnglishTranslation.php

23 lines

Diff 20528

View Options

src/applications/differential/customfield/DifferentialJIRAIssuesField.php