Page MenuHomePhabricator
Differential D8646

Move Releeph branch controllers toward a modern/stable state
ClosedPublic
Actions

Authored by epriestley on Mar 29 2014, 9:19 PM.
Tags
None
Referenced Files
F14344977: D8646.id20503.diff
Thu, Dec 19, 12:55 AM
Unknown Object (File)
Sun, Dec 15, 6:02 PM
Unknown Object (File)
Sun, Dec 15, 6:02 PM
Unknown Object (File)
Sun, Dec 15, 6:02 PM
Unknown Object (File)
Fri, Dec 6, 7:22 AM
Unknown Object (File)
Thu, Dec 5, 7:51 AM
Unknown Object (File)
Thu, Dec 5, 7:41 AM
Unknown Object (File)
Sat, Nov 30, 4:51 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP2712091a7148: Move Releeph branch controllers toward a modern/stable state
Summary

Ref T3644. Ref T3657. Ref T3549. Basically:

  • Move these controllers to modern query/policy infrastructure.
  • Move them to consistent, ID-based URIs.
  • Rename "Project" to "Product"; "Pick Request" to "Pull Request".
  • Clean up a few UI things here and there.
Test Plan
  • Created and edited branches.
  • Opened and closed branches.
  • Viewed branch history.
  • Searched within a branch.
  • Browsed to branches from products.

Diff Detail

Repository
rP Phabricator
Branch
rel9
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/releeph/controller/branch/ReleephBranchViewController.php:49XHP16TODO Comment
Unit
No Test Coverage

Event Timeline

epriestley updated this revision to Diff 20503.Mar 29 2014, 9:19 PM
epriestley retitled this revision from to Move Releeph branch controllers toward a modern/stable state.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added tasks: Restricted Maniphest Task, Restricted Maniphest Task, Restricted Maniphest Task.
Herald added a subscriber: epriestley.Mar 29 2014, 9:19 PM
epriestley updated this revision to Diff 20504.Mar 29 2014, 9:47 PM
  • Fix a URI issue from the BranchView.
btrahan accepted this revision.Mar 31 2014, 9:39 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 31 2014, 9:39 PM
epriestley closed this revision.Apr 12 2014, 11:54 PM
epriestley updated this revision to Diff 20792.

Closed by commit rP2712091a7148 (authored by @epriestley).

Revision Contents
Changeset List

Diff 20504

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/releeph/controller/ReleephController.php

Loading...
View Options

src/applications/releeph/controller/branch/ReleephBranchAccessController.php

Loading...
View Options

src/applications/releeph/controller/branch/ReleephBranchController.php

Loading...
View Options

src/applications/releeph/controller/branch/ReleephBranchCreateController.php

Loading...
View Options

src/applications/releeph/controller/branch/ReleephBranchEditController.php

Loading...
View Options

src/applications/releeph/controller/branch/ReleephBranchHistoryController.php

Loading...
View Options

src/applications/releeph/controller/branch/ReleephBranchViewController.php

Loading...
View Options

src/applications/releeph/controller/project/ReleephProductController.php

Loading...
View Options

src/applications/releeph/controller/project/ReleephProductHistoryController.php

Loading...
View Options

src/applications/releeph/controller/project/ReleephProductViewController.php

Loading...
View Options

src/applications/releeph/storage/ReleephBranch.php

Loading...
Phabricator · Built by Phacility