Page MenuHomePhabricator

Modernize Releeph "Product Activate" controller
ClosedPublic

Authored by epriestley on Mar 28 2014, 12:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 12 2026, 7:03 AM
Unknown Object (File)
Mar 28 2026, 6:59 PM
Unknown Object (File)
Mar 28 2026, 6:54 PM
Unknown Object (File)
Mar 23 2026, 8:23 PM
Unknown Object (File)
Jan 17 2026, 8:22 PM
Unknown Object (File)
Jan 9 2026, 5:08 PM
Unknown Object (File)
Jan 9 2026, 4:49 PM
Unknown Object (File)
Nov 26 2025, 7:25 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPa5ad923573fd: Modernize Releeph "Product Activate" controller
Summary

Ref T3549. A few things here:

  • Releeph has an object called a "Project". We'd like to call this a "Product" instead. See T3549. Rename easy instances that don't break URIs.
  • Releeph has a "ProjectController" which tries to be smart about loading objects. However, it's big and messy and doesn't have the finesse to do policies or needX(...) correctly. It also generates URIs which collide with one another. Introduce "ProductController" to start to move away from it.
  • Some small modernizations to this controller to take advantage of newer infrastructure (like easier dialog rendering).
Test Plan

Deactivated and reactivated products.

Diff Detail

Repository
rP Phabricator
Branch
rel4
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

epriestley retitled this revision from to Modernize Releeph "Product Activate" controller.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: Restricted Maniphest Task.
btrahan edited edge metadata.

Love the project => product rename.

This revision is now accepted and ready to land.Mar 28 2014, 7:54 PM
epriestley updated this revision to Diff 20494.

Closed by commit rPa5ad923573fd (authored by @epriestley).