Page MenuHomePhabricator

Modernize Releeph "Product Activate" controller
ClosedPublic

Authored by epriestley on Mar 28 2014, 12:32 PM.
Tags
None
Referenced Files
F13395283: D8632.id20473.diff
Wed, Jul 3, 2:22 PM
F13395282: D8632.id20494.diff
Wed, Jul 3, 2:22 PM
F13395281: D8632.id.diff
Wed, Jul 3, 2:22 PM
F13393980: D8632.diff
Wed, Jul 3, 3:53 AM
F13361104: D8632.id20473.diff
Tue, Jun 25, 1:00 PM
F13351960: D8632.diff
Sun, Jun 23, 10:56 AM
F13334503: D8632.diff
Tue, Jun 18, 10:55 PM
F13321150: D8632.diff
Fri, Jun 14, 6:28 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPa5ad923573fd: Modernize Releeph "Product Activate" controller
Summary

Ref T3549. A few things here:

  • Releeph has an object called a "Project". We'd like to call this a "Product" instead. See T3549. Rename easy instances that don't break URIs.
  • Releeph has a "ProjectController" which tries to be smart about loading objects. However, it's big and messy and doesn't have the finesse to do policies or needX(...) correctly. It also generates URIs which collide with one another. Introduce "ProductController" to start to move away from it.
  • Some small modernizations to this controller to take advantage of newer infrastructure (like easier dialog rendering).
Test Plan

Deactivated and reactivated products.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Modernize Releeph "Product Activate" controller.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: Restricted Maniphest Task.
btrahan edited edge metadata.

Love the project => product rename.

This revision is now accepted and ready to land.Mar 28 2014, 7:54 PM
epriestley updated this revision to Diff 20494.

Closed by commit rPa5ad923573fd (authored by @epriestley).