Page MenuHomePhabricator

Remove "Release Counter" from Releeph
ClosedPublic

Authored by epriestley on Mar 28 2014, 2:32 AM.
Tags
None
Referenced Files
F14777658: D8628.diff
Fri, Jan 24, 5:12 AM
Unknown Object (File)
Tue, Jan 21, 1:54 PM
Unknown Object (File)
Tue, Jan 21, 11:42 AM
Unknown Object (File)
Fri, Jan 17, 10:29 PM
Unknown Object (File)
Dec 13 2024, 5:06 PM
Unknown Object (File)
Dec 10 2024, 8:44 AM
Unknown Object (File)
Dec 8 2024, 8:04 PM
Unknown Object (File)
Dec 6 2024, 4:12 AM
Subscribers

Details

Reviewers
btrahan
chad
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP4f26b8ffcf1b: Remove "Release Counter" from Releeph
Summary

Fixes T3658. This field doesn't make much sense and doesn't appear to ever have actually been implemented. Particularly, the %N pattern doesn't actually work and I can't find anything which actually calls this stuff or exposes it externally. Facebook doesn't use it (see T3658) and I don't think it's useful in general.

Test Plan

Used grep to look for stuff, edited a project.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Remove "Release Counter" from Releeph.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: Restricted Maniphest Task.
chad added a reviewer: chad.
This revision is now accepted and ready to land.Mar 28 2014, 2:36 AM
epriestley updated this revision to Diff 20491.

Closed by commit rP4f26b8ffcf1b (authored by @epriestley).