Page MenuHomePhabricator
Differential D8602

Rename concrete Harbormaster step implementations
ClosedPublic
Actions

Authored by epriestley on Mar 23 2014, 6:24 PM.
Tags
None
Referenced Files
F13051462: D8602.id20432.diff
Fri, Apr 19, 3:32 AM
F13051461: D8602.id20392.diff
Fri, Apr 19, 3:32 AM
F13051460: D8602.id.diff
Fri, Apr 19, 3:32 AM
Unknown Object (File)
Fri, Apr 12, 10:48 PM
Unknown Object (File)
Thu, Apr 11, 4:44 AM
Unknown Object (File)
Mon, Apr 1, 12:59 AM
Unknown Object (File)
Tue, Mar 26, 7:05 AM
Unknown Object (File)
Tue, Mar 26, 7:01 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T1049: Implement Harbormaster
Commits
Restricted Diffusion Commit
rPcec8d1073150: Rename concrete Harbormaster step implementations
Summary

Ref T1049. For consistency, rename these to "Harbormaster...".

Test Plan

Ran migration, ran builds, everything still works fine.

Diff Detail

Repository
rP Phabricator
Branch
harbor6
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

epriestley updated this revision to Diff 20392.Mar 23 2014, 6:24 PM
epriestley retitled this revision from to Rename concrete Harbormaster step implementations.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T1049: Implement Harbormaster.
Herald added a subscriber: epriestley.Mar 23 2014, 6:24 PM
btrahan accepted this revision.Mar 25 2014, 8:22 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 25 2014, 8:22 PM
epriestley closed this revision.Mar 25 2014, 11:09 PM
epriestley updated this revision to Diff 20432.

Closed by commit rPcec8d1073150 (authored by @epriestley).

Revision Contents
Changeset List

Diff 20392

View Options

resources/sql/autopatches/20140323.harbor.1.renames.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/step/CommandBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterCommandBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterLeaseHostBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterPublishFragmentBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterSleepBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterUploadArtifactBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterWaitForPreviousBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/step/LeaseHostBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/step/PublishFragmentBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/step/SleepBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/step/UploadArtifactBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/step/WaitForPreviousBuildStepImplementation.php

Loading...
Phabricator · Built by Phacility