Page MenuHomePhabricator

Use ApplicationTransactions and CustomField to implement build steps
ClosedPublic

Authored by epriestley on Mar 23 2014, 5:57 PM.

Details

Summary

Ref T1049. Fixes T4602. Moves all the funky field stuff to CustomField. Uses ApplicationTransactions to apply and record edits.

This makes "artifact" fields a little less nice (but still perfectly usable). With D8599, I think they're reasonable overall. We can improve this in the future.

All other field types are better (e.g., fixes weird bugs with "bool", fixes lots of weird behavior around required fields), and this gives us access to many new field types.

Test Plan

Made a bunch of step edits. Here's an example:

Note that:

  • "Required" fields work correctly.
  • the transaction record is shown at the bottom of the page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20389.Mar 23 2014, 5:57 PM
epriestley retitled this revision from to Use ApplicationTransactions and CustomField to implement build steps.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley updated this revision to Diff 20391.Mar 23 2014, 6:15 PM
  • Remove a stray validateSettings() call.
btrahan accepted this revision.Mar 25 2014, 8:19 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 25 2014, 8:19 PM
epriestley closed this revision.Mar 25 2014, 11:08 PM
epriestley updated this revision to Diff 20430.

Closed by commit rPa246c85c6b51 (authored by @epriestley).