Put a <span> around "NOTE:" in Remarkup
ClosedPublic
Actions

Authored by epriestley on Mar 23 2014, 12:19 AM.

Details

Reviewers

btrahan
chad

Commits

rPHUa25afc6c64b0: Put a <span> around "NOTE:" in Remarkup

Summary

I suspect these will look better if we bold/grey the "NOTE:" part.

Test Plan

Ran unit tests. Will try styling next.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20382.Mar 23 2014, 12:19 AM

epriestley retitled this revision from to Put a <span> around "NOTE:" in Remarkup.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

Herald added a subscriber: epriestley.Mar 23 2014, 12:19 AM

Any way to i18n these

This revision is now accepted and ready to land.Mar 23 2014, 12:27 AM

This gets us closer, but we probably need some kind of "this is a translatable list of words, which can have an arbitrary number of items in it, and each language may have a different number of items" thing (which we don't currently have). We need this in a couple of other places, too (one is the Fixes/Closes/Etc T123 type text).