Page MenuHomePhabricator

Normalize sidebar list hover color
ClosedPublic

Authored by chad on Mar 22 2014, 4:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 4, 7:06 PM
Unknown Object (File)
Sun, Aug 25, 9:24 PM
Unknown Object (File)
Thu, Aug 22, 2:45 PM
Unknown Object (File)
Sat, Aug 17, 11:13 PM
Unknown Object (File)
Aug 16 2024, 8:09 AM
Unknown Object (File)
Aug 15 2024, 12:39 AM
Unknown Object (File)
Aug 6 2024, 3:39 PM
Unknown Object (File)
Aug 5 2024, 1:43 AM

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPb849f8920d24: Normalize sidebar list hover color
Summary

This normalizes phui-list's hover color to {$blue} like action-list

Test Plan

View a diviner document

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad retitled this revision from to Normalize sidebar list hover color.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 22 2014, 4:59 AM
chad updated this revision to Diff 20378.

Closed by commit rPb849f8920d24 (authored by @chad).

why does it say I skipped tests?

It's showing the status of the automatic-update-on-commit diff, which lint and tests don't run on. The previous diff shows the gold star for lint.

I think there used to be some weird, hacky code which pretended the results were the same as the previous diff. This is vaguely on my radar to improve, but I don't want to restore the weird hack. I'm leaning toward adding a "this is an automatic udpate which lint and unit tests don't run on" sort of status.

ok fine - I'll ask again in a month when I don't remember this conversation.