Page MenuHomePhabricator

Show primary email in approval queue interface
ClosedPublic

Authored by epriestley on Mar 21 2014, 9:29 PM.
Tags
None
Referenced Files
F13148979: D8589.diff
Sat, May 4, 5:45 AM
Unknown Object (File)
Fri, May 3, 5:47 AM
Unknown Object (File)
Thu, May 2, 8:06 PM
Unknown Object (File)
Tue, Apr 30, 12:12 AM
Unknown Object (File)
Mon, Apr 29, 4:26 PM
Unknown Object (File)
Sat, Apr 27, 11:25 PM
Unknown Object (File)
Thu, Apr 25, 12:14 AM
Unknown Object (File)
Wed, Apr 24, 10:32 PM

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP62e3463ab791: Show primary email in approval queue interface
Summary

Request from @csilvers. When approving users, the primary email address is useful for administrators.

(This queue is only accessible by administrators, so this doesn't expose email information in general.)

Test Plan

Screen_Shot_2014-03-21_at_2.27.41_PM.png (627×1 px, 114 KB)

Diff Detail

Repository
rP Phabricator
Branch
aqueue1
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

epriestley retitled this revision from to Show primary email in approval queue interface.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a subscriber: csilvers.

Maybe only expose this to admins? Or is it implicit that you cannot see this view unless you have the ability to make approvals?

Yeah --

(This queue is only accessible by administrators, so this doesn't expose email information in general.)

Users are only visible on this queue if they're pending approval, and only administrators can see it.

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 25 2014, 7:39 PM
epriestley updated this revision to Diff 20417.

Closed by commit rP62e3463ab791 (authored by @epriestley).