Page MenuHomePhabricator
Differential D8579

Despecialize most task status handling
ClosedPublic
Actions

Authored by epriestley on Mar 21 2014, 11:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 12:12 AM
Unknown Object (File)
Tue, Apr 30, 12:12 AM
Unknown Object (File)
Mon, Apr 29, 3:41 PM
Unknown Object (File)
Sun, Apr 28, 9:03 PM
Unknown Object (File)
Sat, Apr 27, 11:22 PM
Unknown Object (File)
Wed, Apr 24, 10:26 PM
Unknown Object (File)
Wed, Apr 17, 5:38 AM
Unknown Object (File)
Sun, Apr 14, 10:12 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T1812: Allow for arbitrary values for task status
Commits
Restricted Diffusion Commit
rP33bda2d5903b: Despecialize most task status handling
Summary

Ref T1812. Moves most specialized status handling into ManiphestTaskStatus. The only real missing case is reports.

Test Plan

Browsed most of the affected interfaces. Changed task status:

Screen_Shot_2014-03-21_at_4.37.50_AM.png (390×970 px, 44 KB)

Diff Detail

Repository
rP Phabricator
Branch
task1
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

epriestley updated this revision to Diff 20356.Mar 21 2014, 11:42 AM
epriestley retitled this revision from to Despecialize most task status handling.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T1812: Allow for arbitrary values for task status.
Herald added a subscriber: epriestley.Mar 21 2014, 11:42 AM
btrahan accepted this revision.Mar 25 2014, 7:02 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 25 2014, 7:02 PM
epriestley closed this revision.Mar 25 2014, 8:47 PM
epriestley updated this revision to Diff 20412.

Closed by commit rP33bda2d5903b (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
32 lines
src/
applications/
maniphest/
constants/
59 lines
controller/
33 lines
4 lines
mail/
2 lines
phid/
2 lines
query/
10 lines
search/
6 lines
storage/
4 lines
169 lines
view/
2 lines
3 lines
search/
controller/
2 lines
webroot/
rsrc/
js/
application/
maniphest/
2 lines

Diff 20356

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/maniphest/constants/ManiphestTaskStatus.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTransactionSaveController.php

Loading...
View Options

src/applications/maniphest/mail/ManiphestReplyHandler.php

Loading...
View Options

src/applications/maniphest/phid/ManiphestPHIDTypeTask.php

Loading...
View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

Loading...
View Options

src/applications/maniphest/search/ManiphestSearchIndexer.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTask.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTransaction.php

Loading...
View Options

src/applications/maniphest/view/ManiphestTaskListView.php

Loading...
View Options

src/applications/maniphest/view/ManiphestView.php

Loading...
View Options

src/applications/search/controller/PhabricatorSearchAttachController.php

Loading...
View Options

webroot/rsrc/js/application/maniphest/behavior-batch-editor.js

Loading...
Phabricator · Built by Phacility