Paths

Table of Contentst

Differential D8578

fix tab complete for out-of-workdir
ClosedPublic
Actions

Authored by avivey on Mar 20 2014, 6:52 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCd0bab7f34aab: fix tab complete for out-of-workdir

Summary

see https://github.com/facebook/phabricator/issues/546 - arc complete blows up when not
in a workdir.

There's no "is ArcanistWorkingCopyIdentity object valid" method, but getVCSType() looks like the
closest match.

git grep for getProjectRoot didn't reveal any more problmatic call sites.

Test Plan

arc [tab] [tab]

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

avivey updated this revision to Diff 20354.Mar 20 2014, 6:52 PM

avivey retitled this revision from to fix tab complete for out-of-workdir.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

avivey added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers.Mar 20 2014, 6:52 PM

Herald added subscribers: Korvin, epriestley.

Thanks! I have to head to a meeting but I'll look at this later on.

my git-grep from earlier was wrong; there are many more invocations of getProjectRoot() I haven't seed then.

These two places were also testing for the wrong thing. The actual result is mostly just a different error message, but that's also something.

All other callsites are either in lint/unit code, in a "resolve path" context, or in other places where an
API is already expected.

This seems pretty reasonable to me, thanks!

This revision is now accepted and ready to land.Mar 26 2014, 12:33 AM

Closed by commit rARCd0bab7f34aab (authored by @avivey, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

scripts/

arcanist.php

5 lines

src/

workflow/

ArcanistShellCompleteWorkflow.php

4 lines

Diff 20438

View Options

scripts/arcanist.php