Page MenuHomePhabricator

Show profile pictures in subscribers dialog
ClosedPublic

Authored by epriestley on Mar 20 2014, 12:03 AM.
Tags
None
Referenced Files
F13354818: D8573.diff
Mon, Jun 24, 8:03 AM
F13339727: D8573.diff
Wed, Jun 19, 8:14 PM
F13288012: D8573.diff
Tue, Jun 4, 9:40 AM
F13275846: D8573.diff
Fri, May 31, 5:15 AM
F13247570: D8573.id.diff
May 23 2024, 8:36 PM
F13234144: D8573.id20342.diff
May 21 2024, 3:08 AM
F13216383: D8573.diff
May 18 2024, 12:26 AM
F13207817: D8573.id20349.diff
May 16 2024, 4:41 AM
Subscribers

Details

Summary

Ref T4400. Also stops rendering "and 1 other" in subscriber lists, since it looks a bit silly in practice (we can just put the other subscriber there instead). Don't do the "and x others" until X is at least 2.

Test Plan

Viewed/clicked subscriber lists and transactions.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Show profile pictures in subscribers dialog.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 20 2014, 12:42 AM
epriestley updated this revision to Diff 20349.

Closed by commit rPcebc7f4e8bc5 (authored by @epriestley).