Page MenuHomePhabricator

Show profile pictures in subscribers dialog
ClosedPublic

Authored by epriestley on Mar 20 2014, 12:03 AM.
Tags
None
Referenced Files
F14761207: D8573.id.diff
Wed, Jan 22, 11:50 PM
Unknown Object (File)
Tue, Jan 21, 12:15 AM
Unknown Object (File)
Sat, Jan 18, 1:18 AM
Unknown Object (File)
Fri, Jan 17, 2:23 PM
Unknown Object (File)
Wed, Jan 15, 2:28 PM
Unknown Object (File)
Tue, Jan 14, 1:43 AM
Unknown Object (File)
Thu, Jan 9, 12:28 AM
Unknown Object (File)
Fri, Dec 27, 5:41 PM
Subscribers

Details

Summary

Ref T4400. Also stops rendering "and 1 other" in subscriber lists, since it looks a bit silly in practice (we can just put the other subscriber there instead). Don't do the "and x others" until X is at least 2.

Test Plan

Viewed/clicked subscriber lists and transactions.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Show profile pictures in subscribers dialog.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 20 2014, 12:42 AM
epriestley updated this revision to Diff 20349.

Closed by commit rPcebc7f4e8bc5 (authored by @epriestley).