Page MenuHomePhabricator
Differential D8569

Allow ObjectItemListView to show profile images
ClosedPublic
Actions

Authored by epriestley on Mar 19 2014, 11:28 PM.
Tags
None
Referenced Files
F13378184: D8569.diff
Sat, Jun 29, 4:36 AM
F13359758: D8569.diff
Tue, Jun 25, 10:20 AM
F13324545: D8569.diff
Sat, Jun 15, 12:44 AM
F13315203: D8569.diff
Wed, Jun 12, 10:14 AM
F13311897: D8569.diff
Tue, Jun 11, 5:48 AM
F13307292: D8569.diff
Sun, Jun 9, 4:22 PM
F13300360: D8569.diff
Fri, Jun 7, 9:07 AM
F13284759: D8569.diff
Mon, Jun 3, 9:15 AM
View All Files
Subscribers
chad
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T4400: Allow profile pictures to go on object cards
Commits
Restricted Diffusion Commit
rP3d639f5f98f9: Allow ObjectItemListView to show profile images
Summary

Ref T4400. Adds setImageURI() for object card/items.

Test Plan

Screen_Shot_2014-03-19_at_4.27.10_PM.png (265×798 px, 21 KB)

Also tested mobile.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20337.Mar 19 2014, 11:28 PM
epriestley retitled this revision from to Allow ObjectItemListView to show profile images.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added a task: T4400: Allow profile pictures to go on object cards.
Herald added subscribers: chad, epriestley.Mar 19 2014, 11:28 PM
chad accepted this revision.Mar 19 2014, 11:39 PM
chad edited edge metadata.

lgtm

This revision is now accepted and ready to land.Mar 19 2014, 11:39 PM
epriestley closed this revision.Mar 20 2014, 2:26 AM
epriestley updated this revision to Diff 20345.

Closed by commit rP3d639f5f98f9 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
uiexample/
examples/
28 lines
view/
phui/
26 lines
webroot/
rsrc/
css/
phui/
16 lines

Diff 20345

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/uiexample/examples/PHUIObjectItemListExample.php

Loading...
View Options

src/view/phui/PHUIObjectItemView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
Phabricator · Built by Phacility