Differential D8554

Fail more gracefully when rendering transcripts if handle is missing
ClosedPublic
Actions

Authored by epriestley on Mar 17 2014, 8:25 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T4628: Herald transcript viewer: Call getName() on a non-object

Commits

Restricted Diffusion Commit
rP7167a729bf7e: Fail more gracefully when rendering transcripts if handle is missing

Summary

Fixes T4628. I can only partially reproduce the root cause here, but if transcript display rules aren't quite right we should just degrade here rather than fatalling. Transcripts are a messy business by any measure.

Test Plan

Sort-of-reproing transcript renders OK now.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20298.Mar 17 2014, 8:25 PM

epriestley retitled this revision from to Fail more gracefully when rendering transcripts if handle is missing.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4628: Herald transcript viewer: Call getName() on a non-object.

Herald added a subscriber: epriestley.Mar 17 2014, 8:25 PM

btrahan accepted this revision.Mar 17 2014, 8:55 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 17 2014, 8:55 PM

Closed by commit rP7167a729bf7e (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

controller/

HeraldTranscriptController.php

4 lines

Diff 20303

View Options

src/applications/herald/controller/HeraldTranscriptController.php

Fail more gracefully when rendering transcripts if handle is missingClosedPublicActions