Page MenuHomePhabricator

Support `git-format-patch` format in diff parser
ClosedPublic

Authored by epriestley on Mar 15 2014, 4:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 19, 10:50 AM
Unknown Object (File)
Fri, Jul 15, 4:45 PM
Unknown Object (File)
Thu, Jul 14, 4:46 PM
Unknown Object (File)
Sun, Jul 10, 6:46 AM
Unknown Object (File)
Jul 7 2022, 2:59 PM
Unknown Object (File)
Jul 5 2022, 10:09 AM
Unknown Object (File)
Jul 3 2022, 3:42 AM
Unknown Object (File)
Jul 2 2022, 10:45 PM
Subscribers

Details

Summary

Fixes T4063. The git format-patch command produces a special header
and footer which we need to detect, strip, and parse.

Test Plan
  • Added and ran unit tests.
  • Submitted a diff with git format-patch HEAD^ --stdout | arc diff --raw.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Support `git-format-patch` format in diff parser.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 15 2014, 5:08 PM
epriestley updated this revision to Diff 20278.

Closed by commit rARC46fe94db9f8c (authored by @epriestley).