Use viwer-based checks for application visibility when rendering home elements
ClosedPublic
Actions

Authored by epriestley on Mar 15 2014, 3:30 PM.

Details

Reviewers

Maniphest Tasks

T4619: PhabricatorHomeMainController doesn't respect policies

Commits

Restricted Diffusion Commit
rPb3b0ef3647e8: Use viwer-based checks for application visibility when rendering home elements

Summary

Fixes T4619. Currently, even if a viewer can't see Maniphest, they'll still see empty panels on the home page. These panels will always be empty so there's no real policy violation, but it's confusing.

Longer term, dashboards should fix this.

Test Plan

Viewed home page with a user with and without permissions on the apps.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20274.Mar 15 2014, 3:30 PM

epriestley retitled this revision from to Use viwer-based checks for application visibility when rendering home elements.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4619: PhabricatorHomeMainController doesn't respect policies.

Herald added a subscriber: epriestley.Mar 15 2014, 3:30 PM

btrahan accepted this revision.Mar 15 2014, 3:59 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 15 2014, 3:59 PM

Closed by commit rPb3b0ef3647e8 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

base/

PhabricatorApplication.php

47 lines

home/

controller/

PhabricatorHomeMainController.php

26 lines

Diff 20280

View Options

src/applications/base/PhabricatorApplication.php