Page MenuHomePhabricator
Differential D8543

Use modern ApplicationTransactions "no effect" stuff in Maniphest
ClosedPublic
Actions

Authored by epriestley on Mar 14 2014, 10:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 9:30 AM
Unknown Object (File)
Mon, Jan 27, 10:41 PM
Unknown Object (File)
Thu, Jan 23, 4:25 AM
Unknown Object (File)
Thu, Jan 23, 3:34 AM
Unknown Object (File)
Tue, Jan 21, 3:03 PM
Unknown Object (File)
Tue, Jan 21, 3:00 PM
Unknown Object (File)
Tue, Jan 21, 11:37 AM
Unknown Object (File)
Sat, Jan 18, 7:21 AM
View All Files
Subscribers
epriestley
Tokens
"Piece of Eight" token, awarded by btrahan.

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP69eab4196de4: Use modern ApplicationTransactions "no effect" stuff in Maniphest
Summary

Fixes T912. This was very nearly working, it just needed a little tweaking on the last mile.

Test Plan

Made updates with no effect, and updates with an effect. Made a no-effect update and posted just the comment part.

Screen_Shot_2014-03-14_at_3.09.56_PM.png (1×1 px, 178 KB)

Diff Detail

Repository
rP Phabricator
Branch
noop
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

epriestley updated this revision to Diff 20270.Mar 14 2014, 10:11 PM
epriestley retitled this revision from to Use modern ApplicationTransactions "no effect" stuff in Maniphest.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: Restricted Maniphest Task.
Herald added a subscriber: epriestley.Mar 14 2014, 10:11 PM
btrahan accepted this revision.Mar 14 2014, 10:13 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 14 2014, 10:13 PM
epriestley closed this revision.Mar 14 2014, 10:13 PM
epriestley updated this revision to Diff 20271.

Closed by commit rP69eab4196de4 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
controller/
1 line
39 lines
storage/
4 lines
15 lines

Diff 20270

View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTransactionSaveController.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTask.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTransaction.php

Loading...
Phabricator · Built by Phacility