Page MenuHomePhabricator
Differential D8540

Transactions - add "and X others" dialog support to application transactions
ClosedPublic
Actions

Authored by btrahan on Mar 14 2014, 9:19 PM.
Tags
None
Referenced Files
F13816141: D8540.diff
Thu, Sep 19, 1:09 PM
Unknown Object (File)
Sun, Sep 15, 12:19 AM
Unknown Object (File)
Sat, Sep 14, 6:43 PM
Unknown Object (File)
Sat, Sep 14, 6:40 PM
Unknown Object (File)
Sat, Sep 14, 6:40 PM
Unknown Object (File)
Sat, Sep 14, 6:40 PM
Unknown Object (File)
Sat, Sep 7, 11:18 AM
Unknown Object (File)
Tue, Aug 27, 7:20 AM
View All Files
Subscribers
chad
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T4430: Summarize long lists of subscriptions and subscription changes
Commits
Restricted Diffusion Commit
rP3ff9f5f48a45: Transactions - add "and X others" dialog support to application transactions
Summary

Fixes T4430. Basically does a little code massage from the new stuff in D8525 and application transactions to get this working. Adds a new controller to the subscriptions app to make rendering these pretty easy peasy.

Test Plan

Used my test task in D8525 to verify both add and rem versions of these dialogs worked correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan updated this revision to Diff 20261.Mar 14 2014, 9:19 PM
btrahan added a task: T4430: Summarize long lists of subscriptions and subscription changes.
btrahan retitled this revision from to Transactions - add "and X others" dialog support to application transactions.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
btrahan added a subscriber: chad.
Herald added subscribers: Korvin, epriestley.Mar 14 2014, 9:19 PM
btrahan added a comment.Mar 14 2014, 9:20 PM

Screen_Shot_2014-03-14_at_2.19.33_PM.png (1×2 px, 515 KB)

Screen_Shot_2014-03-14_at_2.19.37_PM.png (1×2 px, 507 KB)

Screen_Shot_2014-03-14_at_2.19.41_PM.png (1×2 px, 531 KB)

epriestley accepted this revision.Mar 14 2014, 9:22 PM
epriestley edited edge metadata.

itsawesome

This revision is now accepted and ready to land.Mar 14 2014, 9:22 PM
btrahan closed this revision.Mar 14 2014, 9:27 PM
btrahan updated this revision to Diff 20262.

Closed by commit rP3ff9f5f48a45 (authored by @btrahan).

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
subscriptions/
application/
2 lines
controller/
81 lines
view/
20 lines
transactions/
storage/
20 lines

Diff 20262

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/subscriptions/application/PhabricatorApplicationSubscriptions.php

Loading...
View Options

src/applications/subscriptions/controller/PhabricatorSubscriptionsTransactionController.php

Loading...
View Options

src/applications/subscriptions/view/SubscriptionListStringBuilder.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
Phabricator · Built by Phacility