Paths

Table of Contentst

Differential D8537

Tune cookie behaviors for 'phcid', 'phreg', etc
ClosedPublic
Actions

Authored by epriestley on Mar 14 2014, 7:46 PM.

Tags

None

Referenced Files

	F13253366: D8537.diff
	Sat, May 25, 2:37 AM

	F13231400: D8537.diff
	Tue, May 21, 12:26 AM

	F13219547: D8537.id20264.diff
	Sat, May 18, 7:19 PM

	F13216630: D8537.id.diff
	Sat, May 18, 1:39 AM

	F13187318: D8537.diff
	Sat, May 11, 4:27 AM

	Unknown Object (File)
	Tue, May 7, 6:32 AM

	Unknown Object (File)
	Sun, May 5, 6:29 AM

	Unknown Object (File)
	Fri, May 3, 5:49 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T3471: Be more conservative in overwriting `phcid`

Commits

Restricted Diffusion Commit
rP559c0fe88663: Tune cookie behaviors for 'phcid', 'phreg', etc

Summary

Fixes T3471. Specific issues:

Add the ability to set a temporary cookie (expires when the browser closes).
We overwrote 'phcid' on every page load. This creates some issues with browser extensions. Instead, only write it if isn't set. To counterbalance this, make it temporary.
Make the 'next_uri' cookie temporary.
Make the 'phreg' cookie temporary.
Fix an issue where deleted cookies would persist after 302 (?) in some cases (this is/was 100% for me locally).

Test Plan

Closed my browser, reopned it, verified temporary cookies were gone.
Logged in, authed, linked, logged out.

Diff Detail

Repository

Branch

tempcookie

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

epriestley updated this revision to Diff 20258.Mar 14 2014, 7:46 PM

epriestley retitled this revision from to Tune cookie behaviors for 'phcid', 'phreg', etc.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T3471: Be more conservative in overwriting `phcid`.

Herald added a subscriber: epriestley.Mar 14 2014, 7:46 PM

First I can't have $_GET / $_POST parameters called 'code', and now I can't have $_COOKIE values of 'deleted' ?

Macro suchwow: much sparta such writ

This revision is now accepted and ready to land.Mar 14 2014, 8:06 PM

Yeah, this technically burns users with the username deleted, since it won't prefill in the "Username: ..." field anymore.

We could put some kind of escaping on that cookie if anyone ever complains.

Closed by commit rP559c0fe88663 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

aphront/

AphrontRequest.php

68 lines

applications/

auth/

constants/

PhabricatorCookies.php

32 lines

controller/

PhabricatorAuthLinkController.php

4 lines

PhabricatorAuthLoginController.php

2 lines

PhabricatorAuthStartController.php

6 lines

Diff 20258

src/aphront/AphrontRequest.php

Loading...

src/applications/auth/constants/PhabricatorCookies.php

Loading...

src/applications/auth/controller/PhabricatorAuthLinkController.php

Loading...

src/applications/auth/controller/PhabricatorAuthLoginController.php

Loading...

src/applications/auth/controller/PhabricatorAuthStartController.php

Loading...