Page MenuHomePhabricator

Forbid "." and ".." in slugs
ClosedPublic

Authored by epriestley on Mar 14 2014, 3:44 PM.
Tags
None
Referenced Files
F15537124: D8535.diff
Thu, Apr 24, 12:20 PM
F15521243: D8535.diff
Sun, Apr 20, 12:32 PM
F15433399: D8535.id20247.diff
Mar 24 2025, 11:00 PM
F15392098: D8535.id20244.diff
Mar 15 2025, 1:14 PM
Unknown Object (File)
Feb 14 2025, 10:57 PM
Unknown Object (File)
Jan 18 2025, 3:48 AM
Unknown Object (File)
Jan 14 2025, 9:00 AM
Unknown Object (File)
Dec 30 2024, 9:25 PM
Subscribers

Details

Summary

Fixes T4614. These don't do anything bad or dangerous, but generate unusable pages.

Test Plan
  • Added and executed unit tests.
  • Tried to create pages like /../, /begin/../end/, etc.

Diff Detail

Repository
rP Phabricator
Branch
dotdot
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley retitled this revision from to Forbid "." and ".." in slugs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 14 2014, 3:50 PM
epriestley updated this revision to Diff 20247.

Closed by commit rPf1637961e79f (authored by @epriestley).