Page MenuHomePhabricator
Differential D8530

End Cap for Timeline
ClosedPublic
Actions

Authored by chad on Mar 14 2014, 5:37 AM.
Tags
None
Referenced Files
F15625816: D8530.diff
Sun, May 18, 11:23 AM
Unknown Object (File)
Fri, May 9, 1:49 PM
Unknown Object (File)
Fri, May 9, 9:54 AM
Unknown Object (File)
Thu, May 8, 7:25 AM
Unknown Object (File)
Tue, May 6, 5:15 AM
Unknown Object (File)
Mon, May 5, 6:23 PM
Unknown Object (File)
Mar 27 2025, 5:26 PM
Unknown Object (File)
Mar 15 2025, 3:55 AM
View All Files
Subscribers
aran
btrahan
chad
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T4438: Make a sophisticated end cap for timelines with no content below them
Commits
Restricted Diffusion Commit
rP325737258520: End Cap for Timeline
Summary

End-cap for timeline. Fixes T4438

Test Plan

Tested on a timeline with and without endcap.

Diff Detail

Repository
rP Phabricator
Branch
spacer-end
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

chad updated this revision to Diff 20239.Mar 14 2014, 5:37 AM
chad retitled this revision from to End of Time.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T4438: Make a sophisticated end cap for timelines with no content below them.
chad added a subscriber: btrahan.
Herald added subscribers: chad, Korvin, epriestley, aran.Mar 14 2014, 5:37 AM
chad retitled this revision from End of Time to End Cap for Timeline.Mar 14 2014, 5:38 AM

undefined (538×446 px, 73 KB)

chad added a comment.Mar 14 2014, 5:40 AM

I couldn't think of any CSS-Only means of doing this.

epriestley accepted this revision.Mar 14 2014, 12:51 PM
epriestley edited edge metadata.

It's so sophisticated!

This revision is now accepted and ready to land.Mar 14 2014, 12:51 PM
chad closed this revision.Mar 14 2014, 3:52 PM
chad updated this revision to Diff 20246.

Closed by commit rP325737258520 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
project/
controller/
1 line
transactions/
view/
7 lines
view/
phui/
21 lines
webroot/
rsrc/
css/
phui/
10 lines

Diff 20239

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectEditMainController.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionView.php

Loading...
View Options

src/view/phui/PHUITimelineView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-timeline-view.css

Loading...
Phabricator · Built by Phacility