Page MenuHomePhabricator

Fix "arc diff --verbatim" when updating a revision
ClosedPublic

Authored by epriestley on Mar 14 2014, 1:18 AM.
Tags
None
Referenced Files
F18878078: D8526.id.diff
Nov 6 2025, 2:28 PM
F18872608: D8526.diff
Nov 5 2025, 5:20 AM
F18747037: D8526.id.diff
Oct 3 2025, 2:24 PM
F18734685: D8526.id.diff
Sep 30 2025, 10:59 PM
F18590687: D8526.id.diff
Sep 12 2025, 6:48 AM
F18588390: D8526.id20251.diff
Sep 12 2025, 12:10 AM
F18588173: D8526.id20230.diff
Sep 11 2025, 11:28 PM
F18588144: D8526.id20251.diff
Sep 11 2025, 11:23 PM
Subscribers

Details

Summary

Fixes T4601. The "Differential Revision" field needs to be present in the "editable" version of the message so that --verbatim works correctly. Some day all of this might get rewritten to be a little easier to follow, maybe, but keep things working properly for now.

Test Plan

Used arc diff, arc diff --edit, arc diff --verbatim

Diff Detail

Repository
rP Phabricator
Branch
verbatim
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley retitled this revision from to Fix "arc diff --verbatim" when updating a revision.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 14 2014, 5:33 PM
epriestley updated this revision to Diff 20251.

Closed by commit rPab117c2baf34 (authored by @epriestley).