Add type=submit to AphrontDialogView
ClosedPublic
Actions

Authored by chad on Mar 12 2014, 6:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 17, 2:15 AM

	Unknown Object (File)
	Fri, Jan 17, 12:04 AM

	Unknown Object (File)
	Tue, Dec 24, 4:00 AM

	Unknown Object (File)
	Dec 17 2024, 1:31 PM

	Unknown Object (File)
	Dec 13 2024, 9:51 AM

	Unknown Object (File)
	Dec 10 2024, 5:39 AM

	Unknown Object (File)
	Dec 9 2024, 2:03 AM

	Unknown Object (File)
	Dec 9 2024, 2:03 AM

Subscribers

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP27485bc64415: Add type=submit to AphrontDialogView

Summary

This is required for browsers <= IE7

Test Plan

Inspected HTML for type.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad updated this revision to Diff 20171.Mar 12 2014, 6:27 PM

chad retitled this revision from to Add type=submit to AphrontDialogView.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley, aran.Mar 12 2014, 6:27 PM

epriestley accepted this revision.Mar 12 2014, 6:28 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 12 2014, 6:28 PM

Closed by commit rP27485bc64415 (authored by @chad).

Revision Contents
Changeset List

Path

Size

src/

view/

AphrontDialogView.php

1 line

Diff 20172

View Options

src/view/AphrontDialogView.php

Add type=submit to AphrontDialogViewClosedPublicActions