Paths

Table of Contentst

Differential D8501

Add CustomField to Diffusion and add a "branches" field
ClosedPublic
Actions

Authored by epriestley on Mar 12 2014, 4:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 14, 4:29 PM

	Unknown Object (File)
	Fri, Dec 13, 8:17 AM

	Unknown Object (File)
	Fri, Dec 6, 3:45 PM

	Unknown Object (File)
	Wed, Dec 4, 9:00 PM

	Unknown Object (File)
	Wed, Dec 4, 9:00 PM

	Unknown Object (File)
	Wed, Dec 4, 9:00 PM

	Unknown Object (File)
	Wed, Dec 4, 9:00 PM

	Unknown Object (File)
	Wed, Dec 4, 8:42 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T4588: Add "branches" / "tags" information in Diffusion commit emails

Commits

Restricted Diffusion Commit
rP611f6707204c: Add CustomField to Diffusion and add a "branches" field

Summary

Ref T4588. Request from @zeeg. Adds a "BRANCHES" field to commit emails, so the branches the commit appears on are shown.

I've implemented this with CustomField, but in a very light way.

Test Plan

Used scripts/repository/reparse.php --herald to generate mail, got a BRANCHES section where applicable.

Diff Detail

Repository

Branch

morefields

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/repository/storage/PhabricatorRepositoryCommit.php:257	XHP16	TODO Comment
Advice	src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php:161	XHP16	TODO Comment
Advice	src/infrastructure/customfield/field/PhabricatorCustomField.php:1006	XHP16	TODO Comment

Unit

Tests Passed

Event Timeline

epriestley updated this revision to Diff 20168.Mar 12 2014, 4:36 PM

epriestley retitled this revision from to Add CustomField to Diffusion and add a "branches" field.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4588: Add "branches" / "tags" information in Diffusion commit emails.

epriestley added a subscriber: zeeg.

Herald added subscribers: epriestley, aran.Mar 12 2014, 4:36 PM

Remove some dead code.

btrahan accepted this revision.Mar 12 2014, 6:15 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 12 2014, 6:15 PM

Closed by commit rP611f6707204c (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

7 lines

applications/

repository/

customfield/

PhabricatorCommitBranchesField.php

37 lines

PhabricatorCommitCustomField.php

7 lines

PhabricatorRepositoryCommitCustomField.php

9 lines

storage/

PhabricatorRepositoryCommit.php

27 lines

worker/

PhabricatorRepositoryCommitHeraldWorker.php

17 lines

infrastructure/

customfield/

field/

PhabricatorCustomField.php

18 lines

Diff 20168

src/__phutil_library_map__.php

Loading...

src/applications/repository/customfield/PhabricatorCommitBranchesField.php

Loading...

src/applications/repository/customfield/PhabricatorCommitCustomField.php

Loading...

src/applications/repository/customfield/PhabricatorRepositoryCommitCustomField.php

Loading...

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...

src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php

Loading...

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...