Page MenuHomePhabricator

[herald] Add support for Arcanist Project as a field for Differential revisions
ClosedPublic

Authored by neal on Mar 9 2014, 2:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 10:16 AM
Unknown Object (File)
Thu, Dec 5, 11:15 PM
Unknown Object (File)
Wed, Dec 4, 10:26 PM
Unknown Object (File)
Wed, Dec 4, 10:25 PM
Unknown Object (File)
Wed, Dec 4, 10:25 PM
Unknown Object (File)
Wed, Dec 4, 10:10 PM
Unknown Object (File)
Sun, Dec 1, 3:13 PM
Unknown Object (File)
Nov 26 2024, 5:10 PM

Details

Summary

Useful in cases where there is an Arcanist Project but not a repository tracked by Phabricator for a particular revision.

Test Plan

Created a new rule to flag Differential revisions with a particular Arcanist project, verified that it applied as expected via the test console to revisions with the project specified and with a different project specified.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley edited edge metadata.

We're generally trying to move away from Arcanist Projects in as many cases as possible (since for most use cases they're confusing), but the case you describe is one that we can't really get out of. I don't anticipate ever being able to get rid of them either.

This revision is now accepted and ready to land.Mar 11 2014, 8:14 PM
epriestley updated this revision to Diff 20135.

Closed by commit rP8818252f525c (authored by @neal, committed by @epriestley).