Page MenuHomePhabricator
Differential D8436

Add assertions to no-assertions tests in phabricator/
ClosedPublic
Actions

Authored by epriestley on Mar 7 2014, 2:20 PM.
Tags
None
Referenced Files
F18087140: D8436.diff
Wed, Aug 6, 2:34 AM
F18048225: D8436.id20029.diff
Sun, Aug 3, 1:26 PM
F17969104: D8436.id.diff
Fri, Aug 1, 2:04 PM
F17942303: D8436.diff
Thu, Jul 31, 6:37 AM
Unknown Object (File)
May 25 2025, 9:04 AM
Unknown Object (File)
May 21 2025, 12:33 PM
Unknown Object (File)
May 20 2025, 5:49 AM
Unknown Object (File)
May 6 2025, 7:36 PM
View All Files
Subscribers
aran

Details

Reviewers
leebyron
btrahan
Maniphest Tasks
T4570: ArcanistLinterTestCase::executeTestsInDirectory() should fail when it finds 0 tests.
Commits
Restricted Diffusion Commit
rP0488ce73c4b2: Add assertions to no-assertions tests in phabricator/
Summary

Ref T4570. Add trivial assertions to tests which fail-by-exploding so we can fail tests with no assertions.

Test Plan

Ran arc unit --everything with Arcanist patched to fail with no assertions.

Diff Detail

Repository
rP Phabricator
Branch
noassert1
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

btrahan accepted this revision.Mar 7 2014, 5:48 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 7 2014, 5:48 PM
epriestley closed this revision.Mar 7 2014, 6:02 PM

Closed by commit rP0488ce73c4b2 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
people/
editor/
__tests__/
2 lines
infrastructure/
__tests__/
1 line
storage/
__tests__/
4 lines
lisk/
__tests__/
1 line

Diff 20020

View Options

src/applications/people/editor/__tests__/PhabricatorUserEditorTestCase.php

Loading...
View Options

src/infrastructure/__tests__/PhabricatorInfrastructureTestCase.php

Loading...
View Options

src/infrastructure/storage/__tests__/AphrontIsolatedDatabaseConnectionTestCase.php

Loading...
View Options

src/infrastructure/storage/lisk/__tests__/LiskIsolationTestCase.php

Loading...
Phabricator · Built by Phacility