Page MenuHomePhabricator

Support WOFF files in Celerity and add Source Sans Pro
ClosedPublic

Authored by epriestley on Mar 6 2014, 7:18 PM.
Tags
None
Referenced Files
F14035356: D8430.diff
Sun, Nov 10, 5:36 AM
F14005224: D8430.diff
Sun, Oct 27, 9:31 AM
F13984357: D8430.id20010.diff
Sun, Oct 20, 12:48 PM
F13984344: D8430.id20010.diff
Sun, Oct 20, 12:39 PM
F13979216: D8430.id.diff
Sat, Oct 19, 3:21 AM
F13975131: D8430.id.diff
Fri, Oct 18, 8:55 AM
F13974981: D8430.id20010.diff
Fri, Oct 18, 8:12 AM
Unknown Object (File)
Oct 6 2024, 10:45 PM
Subscribers

Details

Summary
  • Allow Celerity to map and serve WOFF files.
  • Add Source Sans Pro, Source Sans Pro Bold, and the corresponding LICENSE.
  • Add a font-source-sans-pro resource for the font.
Test Plan
  • Changed body font-face to 'Source Sans Pro'.
  • Added require_celerity_resource('font-source-sans-pro') in StandardPageView.

Works in Firefox/Chrome/Safari, at least:

{F123296}

{F123297}

{F123298}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad edited edge metadata.

Oh awesome, I hadn't read the license. It's great that we can include these. SO MANY POSSIBILITIES.

.font-effect-fire-animation {
  -webkit-animation-duration:0.8s;
  -webkit-animation-name:font-effect-fire-animation-keyframes;
  -webkit-animation-iteration-count:infinite;
  -webkit-animation-direction:alternate;
  color: #ffe;
}
This revision is now accepted and ready to land.Mar 6 2014, 7:23 PM

Yeah, my read of the license and the OFL FAQ is that they're very permissive and this is an intended use case -- and that Google Web Fonts are just making web fonts easier, not conveying any licensing. I was also a little surprised by this, since mentally web fonts had some kind of secret sauce in them for me. I think maybe because Adobe got here first, and does have a license-conveying offering? Or just because fonts were historically very closed/protected?

Generally, given that local web fonts seem to be very straightforward (like, this diff didn't require any real hoops be jumped through), I'm surprised by the prevalence of SaaS-ey web font stuff, but I guess there is probably enough of a barrier (e.g., the Firefox header) that most users don't want to bother. It's certainly easier to just include the CSS from Google if packaging isn't important to you for your Wordpress blog or whatever.

Sorry, I screwed this up and landed your change too by accident, since I accidentally branched off my local patch. Let me shoot you a counter-diff to just put us in the right state.