Support WOFF files in Celerity and add Source Sans Pro
ClosedPublic
Actions

Authored by epriestley on Mar 6 2014, 7:18 PM.

Details

Reviewers

btrahan
chad

Commits

Restricted Diffusion Commit
rP270916a26e67: Support WOFF files in Celerity and add Source Sans Pro

Summary

Allow Celerity to map and serve WOFF files.
Add Source Sans Pro, Source Sans Pro Bold, and the corresponding LICENSE.
Add a font-source-sans-pro resource for the font.

Test Plan

Changed body font-face to 'Source Sans Pro'.
Added require_celerity_resource('font-source-sans-pro') in StandardPageView.

Works in Firefox/Chrome/Safari, at least:

{F123296}

{F123297}

{F123298}

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Oh awesome, I hadn't read the license. It's great that we can include these. SO MANY POSSIBILITIES.

.font-effect-fire-animation {
  -webkit-animation-duration:0.8s;
  -webkit-animation-name:font-effect-fire-animation-keyframes;
  -webkit-animation-iteration-count:infinite;
  -webkit-animation-direction:alternate;
  color: #ffe;
}

This revision is now accepted and ready to land.Mar 6 2014, 7:23 PM

Yeah, my read of the license and the OFL FAQ is that they're very permissive and this is an intended use case -- and that Google Web Fonts are just making web fonts easier, not conveying any licensing. I was also a little surprised by this, since mentally web fonts had some kind of secret sauce in them for me. I think maybe because Adobe got here first, and does have a license-conveying offering? Or just because fonts were historically very closed/protected?

Generally, given that local web fonts seem to be very straightforward (like, this diff didn't require any real hoops be jumped through), I'm surprised by the prevalence of SaaS-ey web font stuff, but I guess there is probably enough of a barrier (e.g., the Firefox header) that most users don't want to bother. It's certainly easier to just include the CSS from Google if packaging isn't important to you for your Wordpress blog or whatever.

Closed by commit rP270916a26e67 (authored by @epriestley).

Sorry, I screwed this up and landed your change too by accident, since I accidentally branched off my local patch. Let me shoot you a counter-diff to just put us in the right state.