Page MenuHomePhabricator

Pretty up Diviner with new fonts, colors, lots of spacing
AbandonedPublic

Authored by chad on Mar 6 2014, 5:47 AM.
Tags
None
Referenced Files
F13975360: D8422.id19999.diff
Fri, Oct 18, 9:49 AM
F13970793: D8422.diff
Thu, Oct 17, 9:53 AM
Unknown Object (File)
Oct 5 2024, 7:13 AM
Unknown Object (File)
Oct 3 2024, 9:16 AM
Unknown Object (File)
Oct 1 2024, 10:33 PM
Unknown Object (File)
Sep 20 2024, 3:47 PM
Unknown Object (File)
Sep 20 2024, 1:33 PM
Unknown Object (File)
Sep 4 2024, 7:02 PM

Details

Reviewers
epriestley
Summary

This adds the ability to change fonts in phui-document area's with some ease. Not sure if this is the simplest of ways to accomplish this, but seems reasonable, since we'll not likely do it often.

Test Plan

Test a number of Diviner pages and searches

Diff Detail

Repository
rP Phabricator
Branch
roboto
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

chad updated this revision to Unknown Object (????).Mar 6 2014, 6:43 AM
  • Updates based on LiskDAO
  • link colors
chad updated this revision to Unknown Object (????).Mar 6 2014, 6:57 AM
  • derps

Not 100% sure I'm sold on the violet, but I'll give it a chance. The docs look way more readable to me after this, in any case.

Let me send you a patch first to support WOFF in Celerity, since it looks like we're permitted to do that by the font license and I'd rather not depend on external requests to Google's servers (some installs can't make outbound HTTP requests; other installs probably don't want users including arbitrary CSS from Google). It seems like the same CSS works in Firefox, Chrome and Safari, and I think it's OK to fall back in other cases (alternatively, it's probably pretty easy to support them when we hit issues).

Which violet? For the functions? I think I was up in the air on that one. I do enjoy the hovers though.

It's supported back to IE9, so it should be fine. Fallbacks work in any case.

rP270916 accidentally landed this too, I'll diff you to clean up my mess.

its cool, bro. we solid, yo.