Page MenuHomePhabricator

Improve 404 behavior for new Diviner
ClosedPublic

Authored by epriestley on Mar 5 2014, 6:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 2:31 PM
Unknown Object (File)
Fri, Apr 26, 2:42 PM
Unknown Object (File)
Wed, Apr 24, 10:08 PM
Unknown Object (File)
Mon, Apr 22, 10:19 AM
Unknown Object (File)
Fri, Apr 19, 5:42 PM
Unknown Object (File)
Thu, Apr 11, 8:50 AM
Unknown Object (File)
Thu, Apr 11, 8:50 AM
Unknown Object (File)
Thu, Apr 11, 5:42 AM
Subscribers

Details

Summary

Ref T988. When the user clicks a link we haven't explicitly resolved before, we send them to the /find/ endpoint, but currently just 404 if we can't find the relevant documentation.

Instead, display a more user-friendly error message, since we're probably going to have some of these. Also, make the page title much worse.

Test Plan

Hit a 404 via /find/, got a nicer page.

Diff Detail

Repository
rP Phabricator
Branch
div2
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2014, 8:00 PM