Page MenuHomePhabricator

Improve 404 behavior for new Diviner
ClosedPublic

Authored by epriestley on Mar 5 2014, 6:03 PM.
Tags
None
Referenced Files
F17937056: D8408.diff
Thu, Jul 31, 12:49 AM
F17871246: D8408.id.diff
Mon, Jul 28, 3:35 PM
F17849203: D8408.diff
Sun, Jul 27, 8:23 AM
Unknown Object (File)
Jun 15 2025, 10:08 AM
Unknown Object (File)
May 29 2025, 2:49 PM
Unknown Object (File)
May 28 2025, 10:01 AM
Unknown Object (File)
May 9 2025, 10:26 AM
Unknown Object (File)
Apr 29 2025, 5:59 PM
Subscribers

Details

Summary

Ref T988. When the user clicks a link we haven't explicitly resolved before, we send them to the /find/ endpoint, but currently just 404 if we can't find the relevant documentation.

Instead, display a more user-friendly error message, since we're probably going to have some of these. Also, make the page title much worse.

Test Plan

Hit a 404 via /find/, got a nicer page.

Diff Detail

Repository
rP Phabricator
Branch
div2
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2014, 8:00 PM