Page MenuHomePhabricator

Improve 404 behavior for new Diviner
ClosedPublic

Authored by epriestley on Mar 5 2014, 6:03 PM.
Tags
None
Referenced Files
F14744285: D8408.diff
Tue, Jan 21, 9:00 AM
Unknown Object (File)
Sat, Jan 18, 1:31 PM
Unknown Object (File)
Tue, Dec 31, 8:27 AM
Unknown Object (File)
Sun, Dec 22, 3:47 PM
Unknown Object (File)
Dec 11 2024, 6:10 AM
Unknown Object (File)
Dec 5 2024, 10:33 AM
Unknown Object (File)
Nov 26 2024, 2:56 AM
Unknown Object (File)
Nov 19 2024, 2:58 PM
Subscribers

Details

Summary

Ref T988. When the user clicks a link we haven't explicitly resolved before, we send them to the /find/ endpoint, but currently just 404 if we can't find the relevant documentation.

Instead, display a more user-friendly error message, since we're probably going to have some of these. Also, make the page title much worse.

Test Plan

Hit a 404 via /find/, got a nicer page.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2014, 8:00 PM