Page MenuHomePhabricator

Improve 404 behavior for new Diviner
ClosedPublic

Authored by epriestley on Mar 5 2014, 6:03 PM.
Tags
None
Referenced Files
F19826139: D8408.diff
Sun, Mar 8, 5:37 PM
F19820137: D8408.id19964.diff
Fri, Mar 6, 11:33 AM
F19718636: D8408.id19980.diff
Thu, Feb 12, 4:02 PM
F19711989: D8408.id19980.diff
Wed, Feb 11, 8:01 PM
F19525707: D8408.id.diff
Jan 18 2026, 11:25 AM
F19299999: D8408.id.diff
Dec 23 2025, 2:20 PM
F19299410: D8408.id.diff
Dec 23 2025, 2:02 PM
F19250436: D8408.diff
Dec 22 2025, 7:44 AM
Subscribers

Details

Summary

Ref T988. When the user clicks a link we haven't explicitly resolved before, we send them to the /find/ endpoint, but currently just 404 if we can't find the relevant documentation.

Instead, display a more user-friendly error message, since we're probably going to have some of these. Also, make the page title much worse.

Test Plan

Hit a 404 via /find/, got a nicer page.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2014, 8:00 PM