Page MenuHomePhabricator

Improve 404 behavior for new Diviner
ClosedPublic

Authored by epriestley on Mar 5 2014, 6:03 PM.
Tags
None
Referenced Files
F12198259: D8408.diff
Fri, Sep 29, 12:27 AM
F12161112: D8408.diff
Wed, Sep 6, 2:16 PM
F12144953: D8408.id.diff
Thu, Aug 31, 1:57 PM
Unknown Object (File)
Jul 14 2023, 4:21 PM
Unknown Object (File)
Jul 14 2023, 5:17 AM
Unknown Object (File)
Jun 15 2023, 10:16 PM
Unknown Object (File)
Jun 15 2023, 2:48 PM
Unknown Object (File)
Jun 8 2023, 5:03 PM
Subscribers

Details

Summary

Ref T988. When the user clicks a link we haven't explicitly resolved before, we send them to the /find/ endpoint, but currently just 404 if we can't find the relevant documentation.

Instead, display a more user-friendly error message, since we're probably going to have some of these. Also, make the page title much worse.

Test Plan

Hit a 404 via /find/, got a nicer page.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2014, 8:00 PM